Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gui camera pose #863

Merged
merged 7 commits into from
Jun 18, 2021
Merged

Set gui camera pose #863

merged 7 commits into from
Jun 18, 2021

Conversation

jennuine
Copy link
Contributor

Signed-off-by: Jenn Nguyen jenn@openrobotics.org

🎉 New feature

Closes #101

Summary

Extended the view_angle to allow the user to set the exact camera pose from the GUI.

Test it

  • ign gazebo shapes.sdf
  • From the plugins menu, select View Angle
  • Enter different values

Peek 2021-06-16 18-38

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jennuine
set gui camera pose
67945ed 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine requested a review from chapulina as a code owner June 17, 2021 01:50
@jennuine jennuine self-assigned this Jun 17, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 17, 2021
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #863 (f08cd03) into ign-gazebo3 (01fc2ff) will increase coverage by 12.23%.
The diff coverage is 90.52%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #863       +/-   ##
================================================
+ Coverage        65.71%   77.94%   +12.23%     
================================================
  Files              127      215       +88     
  Lines             6238    12077     +5839     
================================================
+ Hits              4099     9414     +5315     
- Misses            2139     2663      +524
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7876ca3...f08cd03. Read the comment docs.

chapulina
chapulina reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful, I'm tired of echoing the pose topic, then having to convert quaternions to Euler 😅

src/gui/plugins/view_angle/ViewAngle.cc Outdated Show resolved Hide resolved
src/gui/plugins/view_angle/ViewAngle.qml Outdated Show resolved Hide resolved
src/gui/plugins/view_angle/ViewAngle.hh Outdated Show resolved Hide resolved
src/gui/plugins/view_angle/ViewAngle.qml Outdated Show resolved Hide resolved
src/gui/plugins/view_angle/ViewAngle.qml Outdated Show resolved Hide resolved
jennuine added 3 commits June 17, 2021 10:31
@jennuine
Merge branch 'ign-gazebo3' into jennuine/set_cam_pose
7a2c72d 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine
removed circular dependency
2b4c28a 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine
expand spinbox
0cdb38b 
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
chapulina
chapulina approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@nkoenig
Copy link
Contributor

nkoenig commented Jun 18, 2021 •
edited
Loading

I added a header in f08cd03. Let me know if you have objections or suggestions.
viewangle

@chapulina chapulina merged commit 483684f into ign-gazebo3 Jun 18, 2021
@chapulina chapulina deleted the jennuine/set_cam_pose branch June 18, 2021 23:38
@jennuine jennuine mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig nkoenig approved these changes

Assignees

@jennuine jennuine

Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennuine @nkoenig @chapulina