-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D plot GUI plugin #917
3D plot GUI plugin #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a initial review, I'm going a tried in my machine
examples/worlds/plot_3d.sdf
Outdated
<play_pause>true</play_pause> | ||
<step>true</step> | ||
<start_paused>true</start_paused> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, are you following any specific XML style for these suggestions? We haven't been enforcing any blank line policy so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Do you by any chance know why the color of the line changes over time? For example, in your video, the line for the lower arm starts out a light green color and goes to dark green.
Thanks for the reviews, I believe I've addressed all comments ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating. There are a couple of codecheck issues, otherwise LGTM!
Oh, btw, no, I don't. I think this may be an issue on the rendering end though. I'll see if I gather enough to ticket an issue. |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
8025da6
to
362570b
Compare
Retargeted from Fortress to Citadel after iterating:
If anyone wants to use this feature with Fortress before the PR is forward-ported, checkout this commit: 8025da6. I'll merge this into Citadel if CI is happy. |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #917 +/- ##
===============================================
- Coverage 78.16% 77.78% -0.38%
===============================================
Files 218 219 +1
Lines 12372 12566 +194
===============================================
+ Hits 9670 9774 +104
- Misses 2702 2792 +90
Continue to review full report at Codecov.
|
🎉 New feature
Closes #231
Alternative to #332
Summary
Plots the path of entities in the 3D scene, parameters are customizable from SDF and / or the GUI.
WIP while I work on some final usability tweaks, and possibly a test.Ready for review!
Test it
This is what it currently looks like:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸