Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow referencing links in nested models in LiftDrag #955

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Allow referencing links in nested models in LiftDrag #955

merged 3 commits into from
Aug 10, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 2, 2021

🎉 New feature

Closes #479

Summary

This updates the LiftDrag system so that links in nested models can be referenced in the link_name parameter. This an example of using the entitiesFromScopedName function in Util.hh.

Test it

Run the INTEGRATION_lift_drag test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@azeey
Allow referencing links in nested models in LiftDrag
4167695 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from chapulina as a code owner August 2, 2021 21:28
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 2, 2021
@azeey azeey requested a review from jennuine August 5, 2021 17:09
jennuine
jennuine reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some minor comments

examples/worlds/lift_drag_nested.sdf Outdated Show resolved Hide resolved
src/systems/lift_drag/LiftDrag.cc Show resolved Hide resolved
test/integration/lift_drag_system.cc Outdated Show resolved Hide resolved
src/systems/lift_drag/LiftDrag.hh Show resolved Hide resolved
examples/worlds/lift_drag_nested.sdf Outdated Show resolved Hide resolved
@jennuine
Copy link
Contributor

@osrf-jenkins run tests please

@azeey azeey merged commit 5eff5f8 into gazebosim:ign-gazebo5 Aug 10, 2021
@azeey azeey deleted the nested_references_for_systems branch August 10, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SDFormat 1.8 composition
2 participants
@azeey @jennuine