Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 to 9 aug2021 #255

Merged
merged 3 commits into from
Aug 12, 2021
Merged

8 to 9 aug2021 #255

merged 3 commits into from
Aug 12, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 12, 2021

➡️ Forward port

Port ign-transport8 to ign-transport9

Branch comparison: ign-transport9...ign-transport8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 3 commits April 30, 2021 14:07
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@nkoenig nkoenig requested a review from caguero as a code owner August 12, 2021 18:00
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #255 (09cea9a) into ign-transport9 (b58e30c) will decrease coverage by 0.07%.
The diff coverage is 30.00%.

❗ Current head 09cea9a differs from pull request most recent head 2451992. Consider uploading reports for the commit 2451992 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport9     #255      +/-   ##
==================================================
- Coverage           88.98%   88.91%   -0.08%     
==================================================
  Files                  49       49              
  Lines                4668     4674       +6     
==================================================
+ Hits                 4154     4156       +2     
- Misses                514      518       +4     
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.06% <30.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0820a...2451992. Read the comment docs.

@nkoenig nkoenig merged commit 11c22ea into ign-transport9 Aug 12, 2021
@nkoenig nkoenig deleted the 8-to-9-aug2021 branch August 12, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants