Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sdf9 ➡️ sdf12 #1206

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Merge sdf9 ➡️ sdf12 #1206

merged 4 commits into from
Nov 30, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port sdf9 as of 9a7c42a to sdf12. #1118 will be forward-ported in a separate pull request.

Branch comparison: sdf12...9a7c42a

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 4 commits November 17, 2022 09:42
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@scpeters scpeters requested a review from azeey as a code owner November 30, 2022 09:37
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 30, 2022
@scpeters scpeters changed the base branch from sdf13 to sdf12 November 30, 2022 09:37
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1206 (601cf4a) into sdf12 (2dca585) will increase coverage by 0.00%.
The diff coverage is 94.73%.

@@           Coverage Diff           @@
##            sdf12    #1206   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          79       79           
  Lines       13071    13090   +19     
=======================================
+ Hits        12028    12046   +18     
- Misses       1043     1044    +1     
Impacted Files Coverage Δ
src/Camera.cc 89.47% <94.73%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 0642939 into sdf12 Nov 30, 2022
@scpeters scpeters deleted the scpeters/merge_9_12_part1 branch November 30, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants