ign -> gz Migrate Ignition Headers : sdformat #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Gazebo 1️1️
|
needs release of gazebosim/gz-math#483 |
|
@osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## sdf9 #1118 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 63 63
Lines 10093 10093
=======================================
Hits 8918 8918
Misses 1175 1175
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chapulina
reviewed
Sep 2, 2022
methylDragon
force-pushed
the
citadel_header_redirects
branch
from
da294a2 to
e883c1f
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
citadel_header_redirects
branch
from
e883c1f to
e40e5af
Compare
|
we also need to update the minimum version of ignition-math6 needed once we start using |
9 tasks
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
added in 9624a0c |
scpeters
reviewed
Oct 5, 2022
src/parser_urdf.cc
Outdated
| @@ -3484,7 +3484,7 @@ void ReduceSDFExtensionPluginFrameReplace( | |||
| // create new offset xml blocks | |||
| xyzKey = new TiXmlElement("xyzOffset"); | |||
| rpyKey = new TiXmlElement("rpyOffset"); | |||
| correctedOffsetKey = new TiXmlElement("ignition::corrected_offsets"); | |||
| correctedOffsetKey = new TiXmlElement("gz::corrected_offsets"); | |||
There was a problem hiding this comment.
these changes to the element name should be reverted
src/parser_urdf.cc
Outdated
| // remove xyzOffset and rpyOffset | ||
| (*_blobIt)->RemoveChild(rpyKey); | ||
| } | ||
| TiXmlNode* correctedOffsetKey = | ||
| (*_blobIt)->FirstChild("ignition::corrected_offsets"); | ||
| (*_blobIt)->FirstChild("gz::corrected_offsets"); |
There was a problem hiding this comment.
these changes to the element name should be reverted
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
nkoenig
approved these changes
Nov 21, 2022
|
@scpeters, is this safe to merge? |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
just made a last few changes I hadn't yet committed. We can merge when CI is clean |
scpeters
approved these changes
Nov 30, 2022
This was referenced Nov 30, 2022
Merged
Merged
scpeters
added a commit
to gazebo-release/sdformat9-release
that referenced
this pull request
Nov 30, 2022
Required by gazebosim/sdformat#1118. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#784