-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize joint axis xyz vector when parsing from SDFormat #312
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf10 #312 +/- ##
=======================================
Coverage 87.50% 87.51%
=======================================
Files 60 60
Lines 9085 9090 +5
=======================================
+ Hits 7950 7955 +5
Misses 1135 1135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just needs entries in the changelog and migration guide
ready for review from @EricCousineau-TRI |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@osrf-jenkins run tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thanks!!!
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
I've looked through the libsdformat code and we do already use SDF_ASSERT in a few places (Element.cc:970, Param.cc:71), so I've added it in |
Per f2f, if the return type is changed from |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good once the compiler error is fixed
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@osrf-jenkins run tests please |
Per f2f, this is most likely broken due to some oddities with github actions (e.g. fetching opaquely from |
…#312) * Normalize joint axis xyz vector when parsing from SDFormat Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Normalize joint axis xyz vector when parsing from SDFormat Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
@azeey This pull request seem to have introduced the following compiler warnings: https://build.osrfoundation.org/job/ignition_launch-ci-master-bionic-amd64/10/ [Discovered during osrf/buildfarmer#84] |
yes, this has caused some test failures, now that it has been included in the prerelease 10.0.0 the test failures will be fixed by gazebosim/gz-sim#288 |
Closes #307. Note that normalization is done only when parsing from SDFormat, i.e, values set via
JointAxis::SetXyz
are not normalized.