Re-disable tests for #202 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #438 +/- ##
==========================================
+ Coverage 86.26% 86.42% +0.15%
==========================================
Files 59 60 +1
Lines 9188 9294 +106
==========================================
+ Hits 7926 8032 +106
Misses 1262 1262
Continue to review full report at Codecov.
|
|
merging without review to fix failing tests and unblock other PR's |
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 15, 2020
) This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 15, 2020
) This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Dec 15, 2020
This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merged
chapulina
pushed a commit
that referenced
this pull request
Dec 24, 2020
This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
pushed a commit
that referenced
this pull request
Dec 24, 2020
This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of "Enable tests for #202 on macOS with Xcode 12+, add catalina workflow (#414)", since those tests have started failing again in the macOS CI action. It keeps the macOS workflow.
I don't know what has changed or why, but I've re-opened #202 and am disabling the tests again here.