Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ 8.9.1 🏁 #449

Merged
merged 3 commits into from
Dec 29, 2020
Merged

⬆️ 8.9.1 🏁 #449

merged 3 commits into from
Dec 29, 2020

Conversation

chapulina
Copy link
Contributor

Preparing for a last major version 8 release before Ignition Blueprint EOLs in 8 days.

Comparison to 8.9.0:

sdformat8_8.9.0...sdf8

There are no PRs open against sdf8.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Dec 23, 2020
@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #449 (d7b417c) into sdf8 (4bb71b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf8     #449   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files          54       54           
  Lines        7304     7304           
=======================================
  Hits         6394     6394           
  Misses        910      910           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb71b5...d7b417c. Read the comment docs.

@azeey
Copy link
Collaborator

azeey commented Dec 24, 2020

I think we need to backport #438 to sdf8 to fix the build failures on macOS actions.

@chapulina
Copy link
Contributor Author

I think we need to backport #438 to sdf8 to fix the build failures on macOS actions.

Here you go #450

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

I think the Homebrew failure can be ignored. It's just saying that sdformat8 is deprecated:

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  sdformat8

Which is weird, because it should only be deprecated in 3 days.

@chapulina chapulina merged commit 9c4261b into sdf8 Dec 29, 2020
@chapulina chapulina deleted the chapulina/8.9.1 branch December 29, 2020 02:32
@scpeters
Copy link
Member

I think the Homebrew failure can be ignored. It's just saying that sdformat8 is deprecated:

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  sdformat8

Which is weird, because it should only be deprecated in 3 days.

I believe you've already seen this, but for broader visibility, the disable! line in the homebrew formulae was automatically deprecating it, so I removed that in osrf/homebrew-simulation#1256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants