🏁 Dome EOL: deprecate and disable bottles #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chapulina
commented
Dec 21, 2021
chapulina
commented
- Part of EOL collection: Dome gazebo-tooling/release-tools#600
Signed-off-by: Louise Poubel <louise@openrobotics.org>
36 tasks
j-rivero
approved these changes
Dec 21, 2021
|
I need to check if we can still build bottles after this has been merged; we may need to revert until all the dome releases are done |
scpeters
reviewed
Dec 21, 2021
| @@ -16,6 +16,10 @@ class IgnitionDome < Formula | |||
| sha256 cellar: :any, mojave: "25f52cf2b4893b2e98c3a9da733c33c434aa6eb9565f34bead4fb4eb725d6854" | |||
| end | |||
|
|
|||
| disable! date: "2022-01-31", because: "is past end-of-life date" | |||
There was a problem hiding this comment.
adding a disable! tag automatically deprecates immediately
There was a problem hiding this comment.
- So you're saying that the date isn't respected? I was following what we did for Blueprint: 🏁 Blueprint EOL #1242
There was a problem hiding this comment.
- And now I see that was reverted in ignition-blueprint: remove disable! #1256 🙃
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.