10 ➡️ 11 #657
Merged
10 ➡️ 11 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Element::GetElement` may create a child element if it doesn't exist. This makes it a non-const function. Instead of changing this behavior, a new function `Element::FindElement` is added that returns a nullptr if the child element is not found instead of creating a new element. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…Linux (#621) This makes it impossible to pass additional flags at build time, such as the ones needed for building with ASAN Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Error: move << operator from .hh to .cc file Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Fix visibility Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
* parser_urdf: no empty velocity_decay elements This fixes the parser_urdf code to only add <velocity_decay/> elements into links if a parameter is specified in a <gazebo/> tag. Currently there there can be multiple empty <velocity_decay/> tags added to a link. * parser_urdf: only add <gravity/> to links if set This fixes the parser_urdf code to only add <gravity/> elements to links if the parameter has been specified in a <gazebo/> tag. * Add test for link extension tags Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* support parsing inf Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * made ValueFromStringImpl visible Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * type to string mapping Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * added test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * readded bool test case Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * added comment Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
chapulina
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf10tosdf11Extra changes:
environment_maptosdf/1.8/material.sdfoperator<<was already inError.ccin sdf11.Branch comparison: sdf11...sdf10
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)