9 ➡️ 10 #688
Merged
9 ➡️ 10 #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also point use a new codecov url now that sdformat is in the ignitionrobotics org Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* added reminder to update functions Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * corrected comment Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * TODO to Note Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> (cherry picked from commit 232ac5c) Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Refactors two sections of the the function into helper functions, so that `sdf::readXml` doesn't go over 500 lines. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Utilizes ignition-cmake's IgnCodecheck module to create the codecheck target. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Test URDF continuous joint effort/velocity limits * Fix parsing of URDF continuous joint effort/velocity limits Fixes #683. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf10 #688 +/- ##
========================================
Coverage ? 87.81%
========================================
Files ? 65
Lines ? 10403
Branches ? 0
========================================
Hits ? 9135
Misses ? 1268
Partials ? 0 Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port sdf9 to sdf10
Extra changes:
src/windirectory from codecheck configurationBranch comparison: sdf10...sdf9
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸