Guard: more UnknownRecord tests

gcanti · Feb 3, 2021 · 41c5e10 · 41c5e10
1 parent eedc197
commit 41c5e10
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/Guard.ts b/src/Guard.ts
@@ -93,7 +93,7 @@ export const UnknownArray: Guard<unknown, Array<unknown>> = {
  * @since 2.2.0
  */
 export const UnknownRecord: Guard<unknown, Record<string, unknown>> = {
-  is: (u: unknown): u is Record<string, unknown> => u != null && typeof u === 'object' && !Array.isArray(u)
+  is: (u: unknown): u is Record<string, unknown> => u !== null && typeof u === 'object' && !Array.isArray(u)
 }
 
 // -------------------------------------------------------------------------------------

diff --git a/test/Guard.ts b/test/Guard.ts
@@ -285,13 +285,18 @@ describe('Guard', () => {
 
   describe('UnknownRecord', () => {
     it('should accept valid inputs', () => {
-      assert.strictEqual(G.UnknownRecord.is(new Set()), true)
-      assert.strictEqual(G.UnknownRecord.is(new Map()), true)
-      assert.strictEqual(G.UnknownRecord.is(new Stream()), true)
+      assert.deepStrictEqual(G.UnknownRecord.is({}), true)
+      assert.deepStrictEqual(G.UnknownRecord.is(new String()), true)
+      assert.deepStrictEqual(G.UnknownRecord.is(new Number()), true)
+      assert.deepStrictEqual(G.UnknownRecord.is(new Set()), true)
+      assert.deepStrictEqual(G.UnknownRecord.is(new Map()), true)
+      assert.deepStrictEqual(G.UnknownRecord.is(new Stream()), true)
     })
 
     it('should reject invalid inputs', () => {
-      assert.strictEqual(G.UnknownRecord.is([]), false)
+      assert.deepStrictEqual(G.UnknownRecord.is(null), false)
+      assert.deepStrictEqual(G.UnknownRecord.is(undefined), false)
+      assert.deepStrictEqual(G.UnknownRecord.is([]), false)
     })
   })
 })