Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Service Static Instance Bug #2890

Closed
GCHQDev404 opened this issue Feb 16, 2023 · 1 comment · Fixed by #2893 or #2910
Closed

Cache Service Static Instance Bug #2890

GCHQDev404 opened this issue Feb 16, 2023 · 1 comment · Fixed by #2893 or #2910
Assignees
@GCHQDev404
Labels
bug Confirmed or suspected bug
Milestone
v2.0.0-alpha-0.5

Comments

@GCHQDev404
Copy link
Contributor

GCHQDev404 commented Feb 16, 2023 •
edited
Loading

Describe the bug
Cache service is Static, which means that any attempt to use a new cache can wipe/swap the cache.
This is horrendous for FederatedStore which uses the cache to store graphs. This is an Ancient bug but since the internal GraphStorage java object has been removed since #2595 this bug has appeared during docker containers testing.

Truth Table of error and behaviour below.

To Reproduce

  AddGraph with no Cache AddGraph with HashMap Cache AddGraph with JCS Cache
FederatedStore is currently using HashMap Cache Graph is added to HashMap Cache The Cache service continues to be HashMap Cache, the cache is initialised, FederatredStore only contains this new graph. The Cache service is switched to JCS Cache, the cache is initialised, JCS cache is loaded from disc, FederatredStore contains this new graph and anything pre-existing in the cache.
FederatedStore is currently using JCS Cache Graph is added to JCS Cache The Cache service is switched to HashMap Cache, the cache is initialised, FederatredStore only contains this new graph. The Cache service continues to be JCS Cache, the cache is initialised, JCS cache is loaded from disc, FederatredStore contains this new graph and anything pre-existing in the cache.
@GCHQDev404 GCHQDev404 added the bug Confirmed or suspected bug label Feb 16, 2023
@GCHQDev404 GCHQDev404 added this to the v2.0.0-alpha-0.5 milestone Feb 16, 2023
@GCHQDev404 GCHQDev404 changed the title Cache static instance Cache Service Static Instance Bug Feb 16, 2023
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal.
59b23ab
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
Revert "gh-2890 cache service single static instance bug removal."
6eadfdb 
This reverts commit 59b23ab.
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S
f0cd731
@github-actions github-actions bot mentioned this issue Feb 18, 2023
Closed
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S
2a2d2b0
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S Tes…
517580c 
…t fix
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S Tes…
4a9fbdb 
…t fix
GCHQDev404 added a commit that referenced this issue Feb 18, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S Tes…
e0471bf 
…t fix
GCHQDev404 added a commit that referenced this issue Feb 19, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S
d881542
@github-actions github-actions bot mentioned this issue Feb 19, 2023
Merged
GCHQDev404 added a commit that referenced this issue Feb 19, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S Tests
d8c1cd1
GCHQDev404 added a commit that referenced this issue Feb 19, 2023
@GCHQDev404
gh-2890 cache service. delete backwards compatibility 1.12
3c6a2b6
GCHQDev404 added a commit that referenced this issue Feb 19, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. K.I.S.S Tests
6efa7e0
GCHQDev404 added a commit that referenced this issue Feb 19, 2023
@GCHQDev404
gh-2890 cache service single static instance bug removal. spotbugs
521d4a3
GCHQDev404 added a commit that referenced this issue Feb 20, 2023
@GCHQDev404
gh-2890 cache service static instance bug. proof test.
a039e9d
@GCHQDev404 GCHQDev404 self-assigned this Feb 21, 2023
This was referenced Feb 21, 2023
Closed
Closed
@t92549 t92549 linked a pull request Feb 22, 2023 that will close this issue
Gh 2890 cache service static instance bug #2893
Merged
GCHQDev404 added a commit that referenced this issue Feb 22, 2023
@GCHQDev404
Merge remote-tracking branch 'origin/v2-alpha' into gh-2890-cache-ser…
baaeddd 
…vice-static-instance-bug
t92549 pushed a commit that referenced this issue Feb 22, 2023
@GCHQDev404
Gh 2890 cache service static instance bug (#2893)
b9fb46e 
* gh-2890 cache service single static instance bug removal.

* Revert "gh-2890 cache service single static instance bug removal."

This reverts commit 59b23ab.

* gh-2890 cache service single static instance bug removal. K.I.S.S

* gh-2890 cache service single static instance bug removal. K.I.S.S Tests

* gh-2890 cache service. delete backwards compatibility 1.12

* gh-2890 cache service single static instance bug removal. K.I.S.S Tests

* gh-2890 cache service single static instance bug removal. spotbugs

* gh-2890 cache service static instance bug. proof test.

* checkstyle

* gh-2581 getTraits to use operation, tidy up.

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
@t92549
Copy link
Contributor

t92549 commented Feb 22, 2023

Closed by #2893

@t92549 t92549 closed this as completed Feb 22, 2023
GCHQDev404 added a commit that referenced this issue Feb 27, 2023
@GCHQDev404
Merge branch 'v2-alpha' into gh-2890-cache-service-static-instance-bug
96fa94b
GCHQDev404 added a commit that referenced this issue Feb 27, 2023
@GCHQDev404
gh-2890 improvement
e6c40b9
@github-actions github-actions bot mentioned this issue Feb 27, 2023
Merged
GCHQDev404 added a commit that referenced this issue Mar 1, 2023
@GCHQDev404
Merge branch 'v2-alpha' into gh-2890-cache-service-static-instance-bug
f118e78
GCHQDev404 added a commit that referenced this issue Mar 1, 2023
@GCHQDev404
gh-2890 Default cache Improvements
55d34bd
GCHQDev404 added a commit that referenced this issue Mar 1, 2023
@GCHQDev404
gh-2890 Default cache Improvements
4b87665
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
Merge remote-tracking branch 'origin/v2-alpha' into gh-2890-cache-ser…
014c72f 
…vice-static-instance-bug
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2890 cache improvements.
f3f4384
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2890 cache improvements. (#2910)
596f739
@t92549 t92549 linked a pull request Mar 7, 2023 that will close this issue
Gh 2890 cache service static instance bug #2910
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.0.0-alpha-0.5
2 participants
@GCHQDev404 @t92549