Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedStore Double Cache Persistence bug #2887

Closed
GCHQDev404 opened this issue Feb 13, 2023 · 3 comments · Fixed by #2904
Closed

FederatedStore Double Cache Persistence bug #2887

GCHQDev404 opened this issue Feb 13, 2023 · 3 comments · Fixed by #2904
Assignees
@GCHQDev404
Labels
bug Confirmed or suspected bug federated-store Specific to/touches the federated-store module
Milestone
v2.0.0-alpha-0.6

Comments

@GCHQDev404
Copy link
Contributor

Describe the bug
If a Rest Service FederatedStore is started and a sub-FederatedStore is added. The sub store could be added with no persistent cache. This would cause the sub-FederatedStore to become unusable. due to being fetched from cache-built-used each time and retains no information.

If a Rest Service FederatedStore is started with No persistent cache, a sub-FederatedStore could be created with A persistent cache.
@GCHQDev404 GCHQDev404 added bug Confirmed or suspected bug federated-store Specific to/touches the federated-store module labels Feb 13, 2023
@GCHQDev404 GCHQDev404 added this to the v2.0.0-alpha-0.6 milestone Feb 13, 2023
@GCHQDev404
Copy link
Contributor Author

This may have all been fixed by the implementation of #2890

GCHQDev404 added a commit that referenced this issue Feb 23, 2023
@GCHQDev404
gh-2887 stopping of a Subgraph of type FederatedStore being added whi…
74eeb4b 
…le Cache is of type non-persistent HashMapCache
@github-actions github-actions bot mentioned this issue Feb 23, 2023
Merged
GCHQDev404 added a commit that referenced this issue Feb 23, 2023
@GCHQDev404
gh-2887 Test which proves the inner federatedStore does persist with …
b49b8aa 
…HashMapCache.
@GCHQDev404
Copy link
Contributor Author

This has been fixed.

  1. The Cache is no longer splatted by an AddGraph.
  2. The inner federated store which built from cache repeatedly, has its info persisting in cache, because the Outter FederatedStore is keeping the light on for the Cache Service in JVM.

This was revealed by the Federation Recursion test after #2890

GCHQDev404 added a commit that referenced this issue Feb 23, 2023
@GCHQDev404
gh-2887 Test fixed to user correct cache instance due to suffix/name …
d5d21f8 
…change.
@t92549 t92549 linked a pull request Mar 2, 2023 that will close this issue
gh-2887 stopping of a Subgraph of type FederatedStore being added whi… #2904
Merged
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2886 FederatedStore remove double caching accidental collision. (#…
a21e36b 
…2902)

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2886 PR change

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2887 stopping of a Subgraph of type FederatedStore being added whi… (
5d22bf1 
#2904)

* gh-2887 stopping of a Subgraph of type FederatedStore being added while Cache is of type non-persistent HashMapCache

* gh-2887 Test which proves the inner  federatedStore does persist with HashMapCache.

* checkstyle

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
@t92549
Copy link
Contributor

t92549 commented Mar 2, 2023

Closed by #2904

@t92549 t92549 closed this as completed Mar 2, 2023
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
Gh 2903 all caches require suffix to avoid collisions within a federa…
4591638 
…tedstore environment (#2907)

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2903 removing 1.12 cache tests and graphStorage zero argument constructor.

* gh-2903 All Cache requires suffix

* gh-2903 Test changes for Cache requiring suffix

* gh-2903 Cherry Picked, improvements.

* gh-2903 test fix

* gh-2903 merge conflicts

* gh-2903 Cache changes for Score Resolvers.

* gh-2903 spotless

* gh-2903 PR change
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2887 Test fixed to user correct cache instance due to suffix/name …
acced35 
…change.
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
Gh 2906 federatedstore removegraph must clear all associated caches (#…
91ec916 
…2912)

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2903 All Cache requires suffix

* gh-2903 Test changes for Cache requiring suffix

* gh-2903 Cherry Picked, improvements.

* gh-2903 test fix

* gh-2903 tidy.

* gh-2886 PR change

* gh-2886 review

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2906 RemoveGraph to optionally delete Caches.

* gh-2906 spotless.

* gh-2909 duplication

* gh-2906 PR changes.

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers. (#2920)
e84c77a 
* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2903 removing 1.12 cache tests and graphStorage zero argument constructor.

* gh-2903 All Cache requires suffix

* gh-2903 Test changes for Cache requiring suffix

* gh-2903 spotless

* gh-2903 Cherry Picked, improvements.

* gh-2903 test fix

* gh-2903 test fix

* gh-2886 PR change

* gh-2903 tidy.

* gh-2886 review

* gh-2886 PR request

* gh-2886 PR request

* gh-2903 merge conflicts

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 Cache changes for Score Resolvers.

* gh-2903 Cache changes for Score Resolvers.

* gh-2903 spotless

* gh-2909 AddGraph with Handlers.

* gh-2909 merge

* gh-2903 spotless

* gh-2909 improved getting operation declarations json

* gh-2909 duplication

* gh-2909 PR changes.

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
bug Confirmed or suspected bug federated-store Specific to/touches the federated-store module
Projects
None yet
Milestone
v2.0.0-alpha-0.6
2 participants
@GCHQDev404 @t92549