Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedStore to add graphs with Handlers #2909

Closed
GCHQDev404 opened this issue Feb 24, 2023 · 1 comment · Fixed by #2920
Closed

FederatedStore to add graphs with Handlers #2909

GCHQDev404 opened this issue Feb 24, 2023 · 1 comment · Fixed by #2920
Assignees
@GCHQDev404
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module proxy-store Specific to/touches the proxy-store module
Milestone
v2.0.0-alpha-0.6

Comments

@GCHQDev404
Copy link
Contributor

Describe the new feature you'd like
FederatedStore to add graphs with Handlers

Why do you want this feature?
ProxyStore is being effected by Graph builder which forces a NamedViewResolver into the ProxyStore.
This means that Adding a NamedView will go to the remote graph but the forced hook will locally try to find and resolve named view locally when used so proxy will error every time.

The Graph Builder can be modified to only add the NamedViewResolver hook if Proxy Store supports AddNamedView.
However there is situations where a local Proxy may wish to have NamedViews and NamedOperations managed locally.
Currently this means an AddGraph operation would requires a duplicate proxy class with NamedViews and NamedOperations Handlers added. This is frustrating since OperationDeclaration exist and can be loaded in for graphs starting in a rest service.

Describe alternatives you've considered
Duplicate ProxyStore
@GCHQDev404 GCHQDev404 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module proxy-store Specific to/touches the proxy-store module labels Feb 24, 2023
@GCHQDev404 GCHQDev404 added this to the v2.0.0-alpha-0.6 milestone Feb 24, 2023
@GCHQDev404
Copy link
Contributor Author

possible Post V2

GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers.
24d25ba
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers.
650ca9d
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers.
f458c06
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 merge
c06a996
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers.
3d92742
GCHQDev404 added a commit that referenced this issue Mar 2, 2023
@GCHQDev404
gh-2909 merge
a89d778
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 improved getting operation declarations json
c58059b
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 duplication
74d4968
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 duplication
26a5987
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 duplication
b0f113d
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 duplication
dca282e
GCHQDev404 added a commit that referenced this issue Mar 3, 2023
@GCHQDev404
gh-2909 duplication
c84b12a
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
gh-2909 PR changes.
0328c47
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
Gh 2906 federatedstore removegraph must clear all associated caches (#…
91ec916 
…2912)

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2903 All Cache requires suffix

* gh-2903 Test changes for Cache requiring suffix

* gh-2903 Cherry Picked, improvements.

* gh-2903 test fix

* gh-2903 tidy.

* gh-2886 PR change

* gh-2886 review

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2906 RemoveGraph to optionally delete Caches.

* gh-2906 spotless.

* gh-2909 duplication

* gh-2906 PR changes.

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
GCHQDev404 added a commit that referenced this issue Mar 6, 2023
@GCHQDev404
gh-2909 AddGraph with Handlers. (#2920)
e84c77a 
* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2886 FederatedStore remove double caching accidental collision.

* gh-2887 Test fixed to user correct cache instance due to suffix/name change.

* gh-2903 removing 1.12 cache tests and graphStorage zero argument constructor.

* gh-2903 All Cache requires suffix

* gh-2903 Test changes for Cache requiring suffix

* gh-2903 spotless

* gh-2903 Cherry Picked, improvements.

* gh-2903 test fix

* gh-2903 test fix

* gh-2886 PR change

* gh-2903 tidy.

* gh-2886 review

* gh-2886 PR request

* gh-2886 PR request

* gh-2903 merge conflicts

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 PR changes.

* gh-2903 Cache changes for Score Resolvers.

* gh-2903 Cache changes for Score Resolvers.

* gh-2903 spotless

* gh-2909 AddGraph with Handlers.

* gh-2909 merge

* gh-2903 spotless

* gh-2909 improved getting operation declarations json

* gh-2909 duplication

* gh-2909 PR changes.

---------

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
@GCHQDev404 GCHQDev404 linked a pull request Mar 6, 2023 that will close this issue
gh-2909 AddGraph with Handlers. #2920
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module proxy-store Specific to/touches the proxy-store module
Projects
None yet
Milestone
v2.0.0-alpha-0.6
1 participant
@GCHQDev404