Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit testing to GafferPopProperty #3100

Closed
tb06904 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3105
Closed

Add unit testing to GafferPopProperty #3100

tb06904 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3105
Assignees
@tb06904
Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.0

Comments

@tb06904
Copy link
Member

tb06904 commented Nov 16, 2023

Add testing for GafferPopProperty class, currently there is minimal coverage for the class and no dedicated tests these need adding to ensure it is functioning correctly.

Get coverage to at least 80%
@tb06904 tb06904 added the tinkerpop Specific to/touches the tinkerpop module label Nov 16, 2023
@tb06904 tb06904 added this to the v2.2.0 milestone Nov 16, 2023
@tb06904 tb06904 self-assigned this Nov 16, 2023
@tb06904 tb06904 linked a pull request Nov 20, 2023 that will close this issue
Gh-3100: Add unit testing to GafferPopProperty #3105
Merged
@github-actions github-actions bot mentioned this issue Nov 20, 2023
Merged
l46978 pushed a commit that referenced this issue Nov 21, 2023
@tb06904
Gh-3100: Add unit testing to GafferPopProperty (#3105)
050ad8c 
* Improve gafferpopproperty test cases

* add check on property with null value
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tb06904 tb06904

Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Gh-3100: Add unit testing to GafferPopProperty gchq/Gaffer
2 participants
@t92549 @tb06904