Gh-3100: Add unit testing to GafferPopProperty #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3105 +/- ##
=============================================
- Coverage 65.57% 65.56% -0.02%
- Complexity 2663 2667 +4
=============================================
Files 909 909
Lines 29008 29008
Branches 3234 3234
=============================================
- Hits 19023 19020 -3
- Misses 8540 8541 +1
- Partials 1445 1447 +2 ☔ View full report in Codecov by Sentry. |
t92549
approved these changes
Nov 20, 2023
GCHQDeveloper314
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands unit tests for the GafferPopEdges to more rigorously test the GafferPopProperty class is being used and created correctly when properties are added to an edge. Now has > 80% coverage.
Related issue