Sync Fork #1
Merged
Sync Fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an og:image meta tag to every page, and reuses react's og:image for the same. This will mean links shared on twitter will correctly have a react logo as an attached image.
* Update to pixelratio.md - getFontScale() iOS does return user value using getFontScale * Update to pixelratio.md - getFontScale() iOS does return user value using getFontScale
* No Intel HAXM when using Hyper-V The docs [here](https://reactnative.dev/docs/getting-started) for Windows > Android lists the following package as a requirement; * `Performance (Intel ® HAXM)` However, in the case of having Hyper-V enabled, like for Docker, installing that package results in failure; > This computer does not support Intel Virtualization Technology (VT-x) or it is being exclusively used by Hyper-V. HAXM cannot be installed. Please ensure Hyper-V is disabled in Windows Features, or refer to the Intel HAXM documentation for more information. The docs also link an article related to AMD, which also happens to mention Hyper-V; > If you want to use Hyper-V at the same time as the Android Emulator on your Intel processor-based computer, you will also need the same Android Studio and Android Emulator versions as listed above, but with the additional requirements: > > * Enable via Windows Features: "Hyper-V" - Only available for Windows 10 Professional/Education/Enterprise > * Intel Processor : Intel® Core™ processor that supports Virtualization Technology (VT-x), Extended Page Tables (EPT), and Unrestricted Guest (UG) features. Additionally VT-x needs to be enabled in the BIOS. I've just learnt (via trial and error) that the latter means you don't need HAXM at all if you satisfy the above two. When I originally read the article though, I thought it was implying I still need HAXM, and, the react-native docs are not clear on this. * Tweaking copy Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
* remove SegmentedControlIOS images * remove images from versioned docs * add Snack example to the SegmentedControlIOS page
* updated getting-started.md changed step -3 and step - 4 of the Android development environment * Making the steps step-by-step Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
* minor improvements to testing guide * Update testing-overview.md * Update testing-overview.md
I am a also cat -> I am also a cat!
* improve code highlight in 0.62 blog post * fix typos, update internal links
Motivation: * It seems that some of external links to `Watchman` are outdated. Modification: * Fix broken links Result: * The page is updated with the correct links.
Component attribute should be the same as function name, HomeScreen. I've also added ProfileScreen function to complete the example code.
It's not a fork of react, but it is a very notable wrapper - allows using react native on Linux, macOS, and Windows.
This commit fixes the types of Share.sharedAction and Share.dismissedAction.
On Android API levels before 23, the barStyle property is ignored. This change documents this effect to avoid bad surprises.
* add CheckBox page back to the sidebar, add Snack example * add deprecation notice to Checkbox, add deprecated version of the page to 0.61 docs
initialNumToRender was listed as a required prop for the SectionList Component
* App crashes if marginBottom is a string * Update tutorial.md
Was running into issues with this line, turned out I was forgetting to rebuild my project! I'm sure there's better ways to word this, too. In general I think it would be nice to mention rebuilding somewhere near the top.
Co-authored-by: Ricky <rickhanlonii@gmail.com>
I found this section specially hard to read, so I'm proposing some minor tweaks that I think will make it easier to understand. I also added a mention to the fallback values which the function can receive, taking from the original PR which introduced the changes (facebook/react-native#27908) I don't know what the exact policy is on this, but since this was introduced in RN 0.63.0, perhaps this could also be clarified on the docs, as using it from an older version will throw a `_reactNative.PlatformColor is not a function` error.
Replace "standards functions" with "standard functions"
It hasn't been updated in awhile
* Updated Android Environment setup PR regarding issue #1610 Added a quick guide on how to upgrade the project Gradle version to avoid errors when using the lastest version of JDK. Updated the Android Studio installation guide. * Reverted Python and JDK version change, edited tips Reverted JDK suggestions to version 8, added '>' before the Gradle upgrade tip, fixed a sentence regarding Android Studio installation, added a tip regarding build tools that have compatibility with Python3 versions. * Removing Python3 tip * fix Oracle JDK link Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
It didn't look quite right, and I couldn't keep quiet. 😉
Extra "to" in the sentence "React Native lets you to build your own Native Components".
I feel like the word "memory" in this context is confusing, as most people do understand memory to be non-persistent.
…ing technique and like we need a section on Debugging. For future IA discussions. (#2112)
Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.