Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Add missing table aliases to fields mapping for Customer Group filter… #29

Merged
merged 37 commits into from
Jun 10, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15826
… and sorting processor magento#15822

Description

This PR is a fix for magento#15822. Issue is caused by missing table alias prefixes in field mappings for customer group filter and sorting processors.

Fixed Issues

  1. SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined magento/magento2#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined

Manual testing scenarios

Follow the steps described in the relevant issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

danielrenaud and others added 30 commits May 24, 2018 16:14
…count down as more characters are entered

- Refactor based on review comments
…count down as more characters are entered

- Add unit test
…elds list magento#83

 - Merge Pull Request magento/graphql-ce#83 from sergy-gzh/graphql-ce:bugfix/26-imit-list-of-filterable-fields
 - Merged commits:
   1. 38180f2
 - Write plugin to invalidate fulltext
 - Invalidate category_product on after delete for Category resource model
 - Write integration tests
…count down as more characters are entered

- Stabilize builds
…count down as more characters are entered

- Build stabilization
…437-Category-Product-Indexer

[honey] MAGETWO-91437: Catalog_category_product_index table doesn't update after deleting category
…haracters

[borg] MAGETWO-91848: Hint on product option with Maximum Characters should count down as more characters are entered
@gelanivishal gelanivishal merged commit 0017c4f into 2.3-develop Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants