Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

removed category_ids and tax_class_id from filterable fields list #83

Merged
merged 1 commit into from
Jun 9, 2018
Merged

removed category_ids and tax_class_id from filterable fields list #83

merged 1 commit into from
Jun 9, 2018

Conversation

sergy-gzh
Copy link
Member

Tested all attributes from the issue description.
Turns out most of fields mentioned, are not available for filtering already.
Only category_ids and tax_class_id and price were still filterable.
Removed, category_ids and tax_class_id.
price attribute is still filterable. Please confirm that should be removed.

  1. Limit list of filterable product fields #26: Limit list of filterable product fields

To test the issue create HTTP request to magento-domain/graphql
with Body:
{
"query": "{ products(filter: { attribute_code : { eq: "2" }}) {total_count}}"
}

Where attribute_code should be (category_ids or tax_class_id)
Magento should generate an exception with "Unknown field." message

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sergii Gozhedrianov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@sidolov sidolov added the mm18nl label Jun 2, 2018
@misha-kotov
Copy link

@sergy-gzh thanks for looking into this! We can leave the price field as an available filterable field. We have removed it from the original list of fields that we wanted to eliminate as filterable.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@magento-engcom-team
Copy link
Contributor

@sergy-gzh thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@paliarush
Copy link
Contributor

@sergy-gzh Please sign CLA above so we can accept your PR. Thanks

@magento-engcom-team magento-engcom-team merged commit 38180f2 into magento:2.3-develop Jun 9, 2018
@paliarush
Copy link
Contributor

@sergy-gzh the PR has been merged. Thank you for your contribution to GraphQL project!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants