New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] magento/magento2#16184: Fix type error in payment void method #44

Merged

gelanivishal merged 1 commit into 2.3-develop from 2.3-develop-PR-port-16194

Jul 6, 2018

Owner

gelanivishal commented Jul 6, 2018

Original Pull Request

Description

Fixes TypeError for void() method in Directpost payment method of Authorizenet module.

The method expects an argument of DataObject type but instead none is given. Passing the response object fixes the problem.

Fixed Issues (if relevant)

Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given magento/magento2#16184: Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given

Manual testing scenarios

Setup authorizenet
Setup a plugin that uses declineOrder method of the Directpost model
Checkout with authorizenet

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)


          magento#16184: Fix type error in payment void method

a1f5fa5

gelanivishal merged commit b96eedd into 2.3-develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet