Argument 1 passed to Magento\Sales\Model\Order\Payment must be an instance of Magento\Framework\DataObject, none given

[Jakhotiya]

magento2/app/code/Magento/Authorizenet/Model/Directpost.php

Line 820 in cc85cbe

$order->getPayment()->setTransactionId(null)->setParentTransactionId($response->getXTransId())->void();

Preconditions

Magento2 2.2 dev branch

Steps to reproduce

1. Setup authorizenet
2. Setup a plugin that uses declineOrder method of the Directpost model
3. Checkout with authorizenet

Expected result

Order is declined

Actual result

Uncaught TypeError: Argument 1 passed to Magento\Sales\Model\Order\Payment\Interceptor::void() must be an instance of Magento\Framework\DataObject, none given.

Some points to note are

1. void method is not part of the interface \Magento\Sales\Api\Data\OrderPaymentInterface
2. void method is not called with any arguments in declineOrder method of Directpost Model

[xpoback]

@Jakhotiya other methods like capture(), authorize(), refund() are not in the interface as well, so this is either deliberate or just not done yet. The actual problem should now be fixed in the PR above.

[Jakhotiya]

Thanks @xpoback . But I'm wondering why you passed response object to void method? More importantly how did you figure out that you have to pass response received by payment gateway.

[VladimirZaets]

Hi @Jakhotiya. Thank you for your report.
The issue has been fixed in #16194 by @xpoback in 2.2-develop branch
Related commit(s):

• a7839e29562e7bb3a3afd57caa8bc9f7cd9b9144

The fix will be available with the upcoming 2.2.6 release.

[sidolov]

Hi @Jakhotiya. Thank you for your report.
The issue has been fixed in #16801 by @gelanivishal in 2.1-develop branch
Related commit(s):

• 25a71d51afa648ae7940dcd0b5d633fedaa9953d

The fix will be available with the upcoming 2.1.15 release.

[magento-engcom-team]

Hi @Jakhotiya. Thank you for your report.
The issue has been fixed in #16603 by @gelanivishal in 2.3-develop branch
Related commit(s):

• a1f5fa5ea447e6190d2dcfabedd12cc677f263dd

The fix will be available with the upcoming 2.3.0 release.