Skip to content

Conversation

@allenhutchison
Copy link
Contributor

Summary

This PR fixes issue #44 where time functions were returning UTC time instead of the user's local time.

Problem

The getCurrentDate and getCurrentTime functions used new Date().toISOString() which always returns UTC time. This caused incorrect time to be displayed to users in non-UTC timezones.

Solution

Both functions now return a response with three fields:

  • utc: The UTC time (preserved for calendar API compatibility)
  • local: The user's local time (for display purposes)
  • timeZone: The user's timezone (for context)

Example response from getCurrentTime:

{
  "utc": "01:22:21",
  "local": "17:22:21",
  "timeZone": "America/Los_Angeles"
}

Changes

  • TimeService.ts: Updated getCurrentDate and getCurrentTime to return {utc, local, timeZone}
  • index.ts: Updated tool descriptions to explain the dual-format response
  • TimeService.test.ts: Updated tests for the new response format
  • docs/index.md: Updated documentation

Testing

All 330 tests pass.

Fixes #44

- getCurrentDate and getCurrentTime now return {utc, local, timeZone}
- UTC values remain available for calendar/API integrations
- Local values provide user's actual local time for display
- Updated tool descriptions to explain the dual-format response
- Updated tests and documentation

Fixes #44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the time utility functions to provide a more user-centric experience by correctly handling local time. Previously, these functions only returned UTC, which could lead to confusion for users. The update ensures that applications can now display time accurately according to the user's local timezone while still retaining UTC for backend or API compatibility.

Highlights

  • Time Function Output Enhanced: The getCurrentDate and getCurrentTime functions now return an object containing three fields: utc (the UTC time, for API compatibility), local (the user's local time, for display), and timeZone (the user's resolved timezone).
  • Resolved Timezone Discrepancy: This change directly addresses an issue where time functions were incorrectly returning only UTC time, leading to display errors for users in non-UTC timezones.
  • Documentation and Tests Updated: All relevant documentation and tests have been updated to reflect the new output format and ensure correctness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully addresses the issue of providing local time alongside UTC time from the time tools. The changes are well-documented and the tool descriptions have been updated accordingly. My review includes suggestions to improve code maintainability by refactoring duplicated code in TimeService.ts and to strengthen the tests in TimeService.test.ts with more specific assertions.

allenhutchison and others added 3 commits December 1, 2025 17:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Extract duplicated now/timeZone logic into getTimeContext helper
- Strengthen test assertions with format validation (regex)
@allenhutchison allenhutchison merged commit dcfe225 into main Dec 2, 2025
6 checks passed
@allenhutchison allenhutchison deleted the fix/issue-44-local-time branch December 2, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect time displayed

2 participants