chore(css): sync colors for components #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/static/variables.css
Outdated
Comment on lines
2
to
4
| --report-color-failed: rgba(255, 4, 0, 0.9); | ||
| --report-color-skipped: #8c8c8c; | ||
| --report-color-success: #169737; |
There was a problem hiding this comment.
- failed
- skipped
- success
- упал
- пропущен
- успех
Может, fail и skip, чтоб не было двух глаголов прошедшего времени и одного существительного?
There was a problem hiding this comment.
я сначала так и сделал, а потом подумал, что тогда будет рассинхрон с названиями по коду в остальных местах. если все будут за твой вариант, то переделаю (мне и самому так логичнее)
DudaGod
reviewed
Aug 10, 2023
| @@ -0,0 +1,5 @@ | |||
| :root { | |||
There was a problem hiding this comment.
А чего не на stylus? У нас сейчас какая-то солянка из css, less и styl. Я бы все новые создавал с использованием stylus
There was a problem hiding this comment.
расширение могу поменять, да. просто тут нечего "стайлусовать" :)
про наведение порядков у меня отдельная задача есть, до нее тоже дойду
DudaGod
approved these changes
Aug 10, 2023
sipayRT
force-pushed
the
sp.colorScheme
branch
from
3a781c8
to
116ec1a
Compare
sipayRT
force-pushed
the
sp.colorScheme
branch
from
116ec1a
to
0a6bd0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
