Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): sync colors for components #486

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore(css): sync colors for components #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/static/components/header/summary/summary.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@
}

.summary__key_passed {
color: #169737;
color: var(--report-color-success);
}

.summary__key_failed {
color: #cf0c3d;
color: var(--report-color-fail);
}

.summary__key_retries {
color: #ff9a9a;
}

.summary__key_skipped {
color: #8c8c8c;
color: var(--report-color-skip);
}

.summary__value {
Expand Down Expand Up @@ -54,7 +54,7 @@
}

.ui.db-info.db-info_failed {
color: #cf0c3d !important;
color: var(--report-color-fail) !important;
}

.ui.basic.db-info.db-info_failed:hover {
Expand All @@ -67,11 +67,11 @@
}

.db-info__row_success {
color: #038035;
color: var(--report-color-success);
font-weight: bold;
}

.db-info__row_fail {
color: #c00;
color: var(--report-color-fail);
font-weight: bold;
}
8 changes: 4 additions & 4 deletions lib/static/gui.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@

.section_status_success > .section__title .bullet_type-simple:before,
.state-title_success:before {
color: #038035;
color: var(--report-color-success);
}

.section_status_fail > .section__title .bullet_type-simple:before,
.section_status_error > .section__title .bullet_type-simple:before,
.state-title_fail:before,
.state-title_error:before {
color: #c00;
color: var(--report-color-fail);
}

.section_status_skipped > .section__title .bullet_type-simple:before,
Expand Down Expand Up @@ -74,8 +74,8 @@
.section_status_updated > .section__title .bullet_type-simple::before,
.section_status_updated > .section__title .ui.checkbox label:before,
.section_status_updated > .section__title .ui.checkbox label:after {
color: #038035 !important;
border-color: #038035 !important;
color: var(--report-color-success) !important;
border-color: var(--report-color-success) !important;
}

.report_show-only-errors .section_status_updated {
Expand Down
24 changes: 12 additions & 12 deletions lib/static/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,21 +398,21 @@ details[open] > .details__summary:before {
}

.section_status_skipped > .section__title {
color: #8c8c8c;
color: var(--report-color-skip);
}

.section_status_skipped > .section__title .ui.checkbox label:before,
.section_status_skipped > .section__title .ui.checkbox label:after {
color: #8c8c8c !important;
border-color: #8c8c8c !important;
color: var(--report-color-skip) !important;
border-color: var(--report-color-skip) !important;
}

.section_status_skipped > .section__title:hover {
color: #c6c6c6;
}

.section__title_skipped {
color: #8c8c8c;
color: var(--report-color-skip);
cursor: default;
margin-left: 5px;
font-weight: normal;
Expand All @@ -421,7 +421,7 @@ details[open] > .details__summary:before {
}

.section__title.section__title_skipped:hover {
color: #8c8c8c;
color: var(--report-color-skip);
}

.section__title_skipped:before {
Expand All @@ -431,15 +431,15 @@ details[open] > .details__summary:before {
.section_status_success > .section__title,
.state-title_success,
.state-title_updated {
color: #038035;
color: var(--report-color-success);
}

.section_status_success > .section__title .ui.checkbox label:before,
.section_status_success > .section__title .ui.checkbox label:after,
.section_status_updated > .section__title .ui.checkbox label:before,
.section_status_updated > .section__title .ui.checkbox label:after {
color: #038035 !important;
border-color: #038035 !important;
color: var(--report-color-success) !important;
border-color: var(--report-color-success) !important;
}

.section_status_success > .section__title:hover,
Expand All @@ -452,15 +452,15 @@ details[open] > .details__summary:before {
.section_status_error > .section__title,
.state-title_fail,
.state-title_error {
color: #c00;
color: var(--report-color-fail);
}

.section_status_fail > .section__title .ui.checkbox label:before,
.section_status_fail > .section__title .ui.checkbox label:after,
.section_status_error > .section__title .ui.checkbox label:before,
.section_status_error > .section__title .ui.checkbox label:after {
color: #c00 !important;
border-color: #c00 !important;
color: var(--report-color-fail) !important;
border-color: var(--report-color-fail) !important;
}

.section_status_fail > .section__title:hover,
Expand Down Expand Up @@ -668,7 +668,7 @@ details[open] > .details__summary:before {

.skipped__list {
margin: 10px 0;
color: #8c8c8c;
color: var(--report-color-skip);
}

.skipped-test__title {
Expand Down
5 changes: 5 additions & 0 deletions lib/static/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
:root {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А чего не на stylus? У нас сейчас какая-то солянка из css, less и styl. Я бы все новые создавал с использованием stylus

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

расширение могу поменять, да. просто тут нечего "стайлусовать" :)

про наведение порядков у меня отдельная задача есть, до нее тоже дойду

--report-color-fail: rgba(255, 4, 0, 0.9);
--report-color-skip: #8c8c8c;
--report-color-success: #169737;
}
4 changes: 2 additions & 2 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ const staticPath = path.resolve(__dirname, 'build', 'lib', 'static');

module.exports = {
entry: {
report: ['./index.jsx', './styles.css'],
gui: ['./gui.jsx', './styles.css', './gui.css']
report: ['./index.jsx', './variables.css', './styles.css'],
gui: ['./gui.jsx', './variables.css', './styles.css', './gui.css']
},
resolve: {
extensions: ['.js', '.jsx', '.ts', '.tsx']
Expand Down
Loading