Remove dependency on @solana/spl-token v0.1.8
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`spl-token` field's `getAccount().amount` is now a BigInt, instead of a BN. Due to this, some tests needed to be updated as there is no implicit equality comparison between BN and BigInt. The only way I found to compare them was to first turn the BN number to string and then initialise a new BigInt from it. It's kinda ugly but I couldn't find a better way.
✅ Deploy Preview for pensive-hamilton-d73c94 canceled.
|
|
If you end up merging this lmk if you would mind a few more PRs :) I've been cleaning up a bit since I needed to use it for smth, changes for now are:
|
|
Does this fix the current ongoing issue @0xnetfox ? |
|
@peterschwarzdev sorry, just seen the comment This PR isn't related to that issue. My uneducated guess is that the linked issue is related to the changes that ilmoi did to accommodate programmable NFTs at the end of January. Those changes shouldn't break existing farms as far as I know so I'd bet the issue resides on the SDK library. If updating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having difficulties using the gem-farm app as the wallet adapter kept complaining about
getMinBalanceRentForExemptMintnot existing when trying to mint a test token, using@gemworks/gem-farm-ts v0.26.4. Digging a bit I found out that the wallet adapters have a dependency on@solana/spl-token v0.1.8, which is a version from 2 years ago, so I've done a bit of refactoring in order to remove that dependency.The change consists mostly about deleting old imports and re-importing the correct functions, with correct parameters and correct types from the newest version of the spl-token library, and fixing the tests that complained.
The change ended up being bigger than I expected, so I may have fucked up something :D the tests all pass correctly and as far as I tried, the app wallet adapter works correctly now when pointed to the local version of the library.
Let me know if the change is ok or anything needs to be modified :)