Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on @solana/spl-token v0.1.8 #130

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove dependency on @solana/spl-token v0.1.8 #130

wants to merge 5 commits into from

Commits on Feb 25, 2023

  1. updated uses of spl-token-018 in the SDK to use a newer version

    @0xnetfox
    0xnetfox committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e02dab3 View commit details
    Browse the repository at this point in the history

  2. updated uses of spl-token-018 in the tests to use a newer version

    @0xnetfox
    0xnetfox committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    28183a2 View commit details
    Browse the repository at this point in the history

  3. update tests that try to compare BigInt against BN 

    `spl-token` field's `getAccount().amount` is now a BigInt, instead of a BN. Due to this, some tests needed to be updated as there is no implicit equality comparison between BN and BigInt.

The only way I found to compare them was to first turn the BN number to string and then initialise a new BigInt from it. It's kinda ugly but I couldn't find a better way.
    @0xnetfox
    0xnetfox committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    341ed56 View commit details
    Browse the repository at this point in the history

  4. update tests expected error on getAccount

    @0xnetfox
    0xnetfox committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    16604e8 View commit details
    Browse the repository at this point in the history

  5. bump app/gem-bank spl-token version to latest

    @0xnetfox
    0xnetfox committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    a19310d View commit details
    Browse the repository at this point in the history