Skip to content

Commit

Permalink
Define COMMIT_NUMBER environment var (#782)
Browse files Browse the repository at this point in the history
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0.

* Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var.
It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....)  or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER

(cherry picked from commit f176e71)
  • Loading branch information
claudiamurialdo committed Mar 20, 2023
1 parent f453656 commit bee93ba
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/Build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
Write-Output "Packge version to be used: $NUGET_PACKAGE_VERSION"
echo "NUGET_PACKAGE_VERSION=$NUGET_PACKAGE_VERSION" >> $env:GITHUB_ENV
echo "COMMIT_NUMBER=$COMMIT_NUMBER" >> $env:GITHUB_ENV
echo "IsPrerelease=$IsPrerelease" >> $env:GITHUB_ENV
echo "::set-output name=NUGET_PACKAGE_VERSION::$NUGET_PACKAGE_VERSION"
Expand Down

0 comments on commit bee93ba

Please sign in to comment.