Define COMMIT_NUMBER environment var #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute on assembly files which was always 0.
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
…_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
added a commit
that referenced
this pull request
Mar 20, 2023
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0. * Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER (cherry picked from commit f176e71)
claudiamurialdo
added a commit
that referenced
this pull request
Mar 20, 2023
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0. * Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER (cherry picked from commit f176e71)
claudiamurialdo
added a commit
that referenced
this pull request
Mar 20, 2023
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0. * Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER (cherry picked from commit f176e71)
claudiamurialdo
added a commit
that referenced
this pull request
Mar 20, 2023
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0. * Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER (cherry picked from commit f176e71)
claudiamurialdo
added a commit
that referenced
this pull request
Mar 20, 2023
* Define COMMIT_NUMBER environment var to set the right FileVersion attribute on assembly files which was always 0. * Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var. It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER (cherry picked from commit f176e71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the right FileVersion attribute on assembly files (it was always 0).