Logging implementation update #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
requested changes
Sep 4, 2023
...tnetcore/Providers/Logging/GeneXus.Log.Azure.AzureAppInsights/AzureAppInsightsLogProvider.cs
Outdated
Show resolved
Hide resolved
...tnetcore/Providers/Logging/GeneXus.Log.Azure.AzureAppInsights/AzureAppInsightsLogProvider.cs
Outdated
Show resolved
Hide resolved
...tnetcore/Providers/Logging/GeneXus.Log.Azure.AzureAppInsights/AzureAppInsightsLogProvider.cs
Outdated
Show resolved
Hide resolved
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
And avoid security transparent problems with .NET Framework (that requires setting [assembly: SecurityRules(SecurityRuleSet.Level1)]) Add a unit test for new logging interface.
Cherry pick to beta success |
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
…ot needed outside the assembly.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Set GetLogFactory as internal.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Add impl for Application Insights logging.
Cherry pick to beta failed, 6 conflicted files in commit 9e6c779
|
sjuarezgx
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Manual cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
…cts that use GxClasses.csproj.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta failed, 1 conflicted file in commit 02a050e
|
Manual cherry pick to beta success |
…for LoggingEvent, where the thread name is only ignored when it matches the default name, which was '.NET Thread Pool Worker' in .NET 6. In .NET 8, the new default name is '.NET TP Worker'.
Cherry pick to beta success |
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
approved these changes
Nov 1, 2023
claudiamurialdo
added a commit
that referenced
this pull request
Nov 10, 2023
Eliminate any unnecessary using statements, specifically the log4net ones that complement PR #871.
claudiamurialdo
added a commit
that referenced
this pull request
Nov 10, 2023
Eliminate any unnecessary using statements, specifically the log4net ones that complement PR #871. (cherry picked from commit c4fcee9) # Conflicts: # dotnet/src/dotnetcore/GxClasses.Web/Notifications/WebSocket/WSHandler.cs # dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs # dotnet/src/dotnetframework/GxClasses/Core/Web/HttpAjaxContext.cs # dotnet/src/dotnetframework/GxClasses/Domain/GXGeolocation.cs # dotnet/src/dotnetframework/GxClasses/Domain/GxCollections.cs # dotnet/src/dotnetframework/GxClasses/Domain/GxGenericCollections.cs # dotnet/src/dotnetframework/GxClasses/Helpers/GXUtilsGeospatial.cs # dotnet/src/dotnetframework/GxClasses/Helpers/JSONHelper.cs # dotnet/src/dotnetframework/GxClasses/Middleware/GXHttp.cs # dotnet/src/dotnetframework/GxClasses/Middleware/GXHttpServices.cs # dotnet/src/dotnetframework/GxClasses/Model/GXBaseObject.cs # dotnet/src/dotnetframework/GxClasses/Model/GXSilentTrn.cs # dotnet/src/dotnetframework/GxClasses/Model/GXWebProcedure.cs # dotnet/src/dotnetframework/GxClasses/Services/GxRestWrapper.cs # dotnet/src/dotnetframework/GxClasses/View/GXWebControls.cs # dotnet/src/dotnetframework/GxWebSocket/WSHandler.cs # dotnet/src/dotnetframework/Projects/StoreManager/Store/StoreManager.cs # dotnet/src/dotnetframework/Providers/Storage/GXAmazonS3/ExternalProviderS3.cs
claudiamurialdo
added a commit
that referenced
this pull request
Nov 10, 2023
Eliminate any unnecessary using statements, specifically the log4net ones that complement PR #871.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:104587
Start implementation of logging using the Net logging API.