Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the performance of Log API methods #912

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Conversation

claudiamurialdo
Copy link
Collaborator

The configLoaded flag was not updated at the appropriate moment.
It been occurring since the modifications introduced in #871.
Issue:103027

The configLoaded flag was not updated at the appropriate moment.
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 6, 2023 20:15 — with GitHub Actions Inactive
ggallotti
ggallotti previously approved these changes Dec 6, 2023
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 026d74a
  • dotnet/DotNetStandardClasses.sln

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Dec 7, 2023
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Dec 7, 2023
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 2 conflicted files in commit 47571ec
  • dotnet/src/dotnetframework/GxClasses/Diagnostics/Log.cs
  • dotnet/src/dotnetframework/GxClasses/Model/gxproc.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Dec 7, 2023
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Dec 7, 2023
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 7, 2023 18:52 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 7, 2023 18:59 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 7, 2023 19:42 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 37fcfe3
  • dotnet/src/dotnetframework/GxClasses/Helpers/GXLogging.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Dec 7, 2023
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 7, 2023 19:52 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests December 7, 2023 20:22 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo changed the title Remove unused configurationLoaded field. Enhance the performance of Log API methods Dec 7, 2023
@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Dec 7, 2023
@claudiamurialdo claudiamurialdo merged commit 7c61fef into master Dec 8, 2023
5 checks passed
@claudiamurialdo claudiamurialdo deleted the logging-loader branch December 8, 2023 20:29
claudiamurialdo added a commit that referenced this pull request Dec 8, 2023
* Remove unused configurationLoaded field.
The configLoaded flag was not updated at the appropriate moment.

* Enhance the performance of Log API methods

* Remove unneeded reflection for GXLoggerFactory.GetLogger.

* Enable test on DEBUG.

* Temporarily disabling test.

* Eliminate overhead in the Log API when logging is disabled.

* Remove more unneeded reflection when creating logger instance.

* Remove overhead at TraceRow method when log is turned off.

* Improve GXLoggerLog4Net.TraceEnabled() method performance.

* Performance improvement at methods GXLoggerLog4Net.Debug and GXLoggerLog4Net.Trace

(cherry picked from commit 7c61fef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants