-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the performance of Log API methods #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configLoaded flag was not updated at the appropriate moment.
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 6, 2023 20:15 — with
GitHub Actions
Inactive
ggallotti
previously approved these changes
Dec 6, 2023
claudiamurialdo
had a problem deploying
to
external-storage-tests
December 7, 2023 15:44 — with
GitHub Actions
Failure
Cherry pick to beta failed, 1 conflicted file in commit 026d74a
|
Manual cherry pick to beta success |
Cherry pick to beta failed, 2 conflicted files in commit 47571ec
|
claudiamurialdo
had a problem deploying
to
external-storage-tests
December 7, 2023 17:18 — with
GitHub Actions
Failure
Manual cherry pick to beta success |
claudiamurialdo
had a problem deploying
to
external-storage-tests
December 7, 2023 18:15 — with
GitHub Actions
Failure
Cherry pick to beta success |
Cherry pick to beta success |
claudiamurialdo
had a problem deploying
to
external-storage-tests
December 7, 2023 18:38 — with
GitHub Actions
Failure
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 7, 2023 18:52 — with
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 7, 2023 18:59 — with
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 7, 2023 19:42 — with
GitHub Actions
Inactive
Cherry pick to beta failed, 1 conflicted file in commit 37fcfe3
|
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 7, 2023 19:52 — with
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
December 7, 2023 20:22 — with
GitHub Actions
Inactive
claudiamurialdo
changed the title
Remove unused configurationLoaded field.
Enhance the performance of Log API methods
Dec 7, 2023
Manual cherry pick to beta success |
claudiamurialdo
added a commit
that referenced
this pull request
Dec 8, 2023
* Remove unused configurationLoaded field. The configLoaded flag was not updated at the appropriate moment. * Enhance the performance of Log API methods * Remove unneeded reflection for GXLoggerFactory.GetLogger. * Enable test on DEBUG. * Temporarily disabling test. * Eliminate overhead in the Log API when logging is disabled. * Remove more unneeded reflection when creating logger instance. * Remove overhead at TraceRow method when log is turned off. * Improve GXLoggerLog4Net.TraceEnabled() method performance. * Performance improvement at methods GXLoggerLog4Net.Debug and GXLoggerLog4Net.Trace (cherry picked from commit 7c61fef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configLoaded flag was not updated at the appropriate moment.
It been occurring since the modifications introduced in #871.
Issue:103027