Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failing due to popups #985

Closed
Robinlovelace opened this issue Sep 6, 2023 · 3 comments
Closed

CI failing due to popups #985

Robinlovelace opened this issue Sep 6, 2023 · 3 comments

Comments

@Robinlovelace
Copy link
Collaborator

This is the error message:

Quitting from lines 895-896 [raster-intro-plot] (02-spatial-data.Rmd)

! object 'popup.vars' not found

Source: https://github.com/geocompx/geocompr/actions/runs/6098697715/job/16549109312?pr=984

I guess it was caused by recent changes in tmap so heads-up @mtennekes. Will take a look.
@Robinlovelace
Copy link
Collaborator Author

Also hitting this after updates to terra:

Quitting from lines 1038-1040 [unnamed-chunk-12] (02-spatial-data.Rmd)
Error in `nlyr()`:
! no slot of name "pnt" for this object of class "SpatRaster"

@Robinlovelace
Copy link
Collaborator Author

Updstream issue: r-tmap/tmap#766

Robinlovelace added a commit that referenced this issue Sep 6, 2023
@Robinlovelace
Turn some things off, fix CI
de42369 
See #985 and r-tmap/tmap#766
Robinlovelace added a commit that referenced this issue Sep 8, 2023
@Robinlovelace
intro tweaks2 (#984)
f4dfa8a 
* Tweak intro

* Shorten intro

* Explain advantages of getting started with R

* More prose refactoring

* Turn some things off, fix CI

See #985 and r-tmap/tmap#766

* Remove errant tmap_mode()

* Remove magick dependency

* Uncomment another line...

* Use ghcr for binder image

* Uncomment tmap-related lines

* Improve description of geocomp in other languages

* Add link to geocompy
github-actions bot pushed a commit that referenced this issue Sep 8, 2023
@Robinlovelace
Deploy commit: intro tweaks2 (#984)
8fdd717 
* Tweak intro

* Shorten intro

* Explain advantages of getting started with R

* More prose refactoring

* Turn some things off, fix CI

See #985 and r-tmap/tmap#766

* Remove errant tmap_mode()

* Remove magick dependency

* Uncomment another line...

* Use ghcr for binder image

* Uncomment tmap-related lines

* Improve description of geocomp in other languages

* Add link to geocompy f4dfa8a
@Robinlovelace
Copy link
Collaborator Author

Seems to be fixed to me. Heads-up @Nowosad in case I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Robinlovelace