-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intro tweaks2 #984
Merged
Merged
intro tweaks2 #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Robinlovelace
commented
Sep 6, 2023
- Tweak intro
- Shorten intro
- Explain advantages of getting started with R
- More prose refactoring
r-tmap/tmap#768 causing the build to fail I think. Happy to wait until it's fixed as it will break the workflows. |
Heads-up guys I think this is good to go. Fairly non-controversial and some improvements in there I think. Review pre or post merge welcome, let's hope actions pass! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Tweak intro * Shorten intro * Explain advantages of getting started with R * More prose refactoring * Turn some things off, fix CI See #985 and r-tmap/tmap#766 * Remove errant tmap_mode() * Remove magick dependency * Uncomment another line... * Use ghcr for binder image * Uncomment tmap-related lines * Improve description of geocomp in other languages * Add link to geocompy f4dfa8a
Nice improvements @Robinlovelace -- I just made a small cleaning to it (79416e6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.