Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Brewer Club Match - Accent Insensitive Search #1504

Closed
tmack8001 opened this issue Feb 12, 2024 · 3 comments
Closed

Enhancement: Brewer Club Match - Accent Insensitive Search #1504

tmack8001 opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
enhancement Suggestion for future enhancement. in latest master commit Fix is in latest commit to master. Not in release. v2.7.0

Comments

@tmack8001
Copy link
Contributor

Reviewed the Release Notes?
Please review the complete Release Notes on brewingcompetitions.com prior to making your request. Your enhancement may have already been incorporated into the core code.

Is your enhancement or feature request related to a problem? Please describe.
When club members search for "The Bru Club" our club entry doesn't show up as it is spelled with a punctuated letter, "The Brü Club"

Describe the solution you'd like:
When filtering a list, it is best to filter the list by stripping out any extra character punctuation (not everyone knows the way to type punctuated characters : umlauts, accents, etc).

image image
@tmack8001 tmack8001 added the enhancement Suggestion for future enhancement. label Feb 12, 2024
@tmack8001 tmack8001 changed the title Enhancement: Club Match Excluding Character Punctuation Enhancement: Brewer Club Match - Accent Insensitive Search Feb 12, 2024
@tmack8001
Copy link
Contributor Author

I checked the underlying implementation to see what would it take to do this since the filtering is performed client-side via bootstrap-select logic.

There was a PR in bootstrap-select that performs the expected logic via data-live-search-normalize="true" - snapappointments/bootstrap-select#1686

The version that is currently pinned in BCOEM is v 1.12.0 whereas the logic desired was released in v1.13.4 back in 2018 (source)

@geoffhumphrey
Copy link
Owner

Confirmed - and thanks for reporting and doing some further research. The next version will update to Bootstrap Select 1.13.18 and add the data-live-search-normalize="true" specification to each dropdown that employs the function.

@geoffhumphrey geoffhumphrey self-assigned this Feb 13, 2024
@tmack8001
Copy link
Contributor Author

Ah awesome @geoffhumphrey !
Was going to dive in and try to provide this fix myself, but didn't have the time yet. Appreciate the assistance.

@geoffhumphrey geoffhumphrey added the in latest master commit Fix is in latest commit to master. Not in release. label Feb 14, 2024
@geoffhumphrey geoffhumphrey added this to the v2.7.0 Release milestone Feb 21, 2024
cgspeck pushed a commit to cgspeck/brewcompetitiononlineentry that referenced this issue May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestion for future enhancement. in latest master commit Fix is in latest commit to master. Not in release. v2.7.0
Projects
None yet
Development

No branches or pull requests

2 participants