chore: drop requirements-dev (#208)

* chore: add optional dev deps to pyproject

* chore: update gitpod for dev

* chore: update ci with dev deps

* fix: switch to pyproject installation for publishing ci

* fix: drop old file name

* style: run black

.github/workflows/pythonpublish.yml

@@ -22,5 +22,5 @@ jobs:
         TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
         TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
       run: |
-        python setup.py sdist bdist_wheel
+        python -m build
         twine upload dist/*

.github/workflows/testing.yml

@@ -31,9 +31,7 @@ jobs:
       run: |
         conda install --yes numpy mkl-service
         conda install --yes pytorch==${{ matrix.pytorch-version }} cpuonly -c pytorch
-        conda install --yes --file requirements-dev.txt
-        conda install --yes conda-build
-        conda develop .
+        pip install -e ."[dev]"
     - name: Run info
       shell: bash -l {0}
       run: |

.gitpod.yml

@@ -10,10 +10,10 @@ tasks:
       micromamba create -yn env pip -c conda-forge
       micromamba activate env
       micromamba install -y torch scipy numpy -c conda-forge
-      pip install -r requirements-dev.txt
     command: |
       micromamba activate env
       pip install -e .
+      pip install -e ."[dev]"
 vscode:
   extensions:
     - eamodio.gitlens

geoopt/manifolds/base.py

@@ -295,7 +295,7 @@ def check_vector_on_tangent(
         ok_point=False,
         explain=False,
         atol=1e-5,
-        rtol=1e-5
+        rtol=1e-5,
     ) -> Union[Tuple[bool, Optional[str]], bool]:
         """
         Check if :math:`u` is lying on the tangent space to x.
@@ -915,7 +915,7 @@ def origin(
         *size: Union[int, Tuple[int]],
         dtype=None,
         device=None,
-        seed: Optional[int] = 42
+        seed: Optional[int] = 42,
     ) -> torch.Tensor:
         """
         Create some reasonable point on the manifold in a deterministic way.

geoopt/manifolds/scaled.py

@@ -171,7 +171,7 @@ def inner(
         v: torch.Tensor = None,
         *,
         keepdim=False,
-        **kwargs
+        **kwargs,
     ) -> torch.Tensor:
         return self.base.inner(x, u, v, keepdim=keepdim, **kwargs)
 

geoopt/manifolds/siegel/vvd_metrics.py

@@ -161,7 +161,6 @@ def compute_metric(self, v: torch.Tensor, keepdim=True) -> torch.Tensor:
 
 
 class SiegelMetricFactory:
-
     metrics_map = {
         SiegelMetricType.RIEMANNIAN: RiemannianMetric,
         SiegelMetricType.FINSLER_ONE: FinslerOneMetric,

geoopt/manifolds/symmetric_positive_definite.py

@@ -273,6 +273,6 @@ def origin(
         *size: Union[int, Tuple[int]],
         dtype=None,
         device=None,
-        seed: Optional[int] = 42
+        seed: Optional[int] = 42,
     ) -> torch.Tensor:
         return torch.diag_embed(torch.ones(*size[:-1], dtype=dtype, device=device))

pyproject.toml

@@ -34,6 +34,21 @@ homepage = "https://github.com/geoopt/geoopt"
 repository = "https://github.com/geoopt/geoopt"
 documentation = "https://geoopt.readthedocs.io/en/latest/"
 
+[project.optional-dependencies]
+dev = [
+    "pytest",
+    "pytest-cov",
+    "pytest-html",
+    "black",
+    "coveralls",
+    "twine",
+    "wheel",
+    "sphinx",
+    "seaborn",
+    "pydocstyle>=6.3.0",
+    "pylint"
+]
+
 [tool.pydocstyle]
 convention = "numpy"
 add-ignore = [

tests/test_lorentz_math.py

@@ -109,7 +109,7 @@ def test_geodesic_segement_unit_property(a, b, k):
         # TODO: analyze corner cases for geodesic
         dist_ab_t0mt1[1:],
         true_distance_travelled[1:],
-        **tolerance[k.dtype]
+        **tolerance[k.dtype],
     )