Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop requirements-dev #208

Merged
merged 6 commits into from
Mar 20, 2023
Merged

chore: drop requirements-dev #208

merged 6 commits into from
Mar 20, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Mar 7, 2023

Following work done in #201, this PR aims to move the packages required for development within the pyproject.toml.

Changes were also made to the Github Actions workflows files, to work with pyproject.toml.

There is also a fix to the python publishing CI which wasn't changed in #201.

@codecov-commenter
Copy link

Codecov Report

Merging #208 (d4e5c33) into master (7474c9b) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   79.53%   79.50%   -0.03%     
==========================================
  Files          41       41              
  Lines        3630     3630              
==========================================
- Hits         2887     2886       -1     
- Misses        743      744       +1     
Impacted Files Coverage Δ
geoopt/manifolds/base.py 80.52% <ø> (ø)
geoopt/manifolds/scaled.py 91.81% <ø> (ø)
geoopt/manifolds/siegel/vvd_metrics.py 92.85% <ø> (ø)
geoopt/manifolds/symmetric_positive_definite.py 85.39% <ø> (ø)
geoopt/utils.py 68.29% <0.00%> (-1.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SauravMaheshkar
Copy link
Contributor Author

@ferrine Request for Review

@SauravMaheshkar SauravMaheshkar self-assigned this Mar 20, 2023
@SauravMaheshkar SauravMaheshkar added the enhancement New feature or request label Mar 20, 2023
@SauravMaheshkar SauravMaheshkar merged commit 5f9f566 into geoopt:master Mar 20, 2023
@SauravMaheshkar SauravMaheshkar deleted the refactor branch March 20, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants