Added borrowed value conversion traits for geo_types. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
commented
Aug 19, 2022
metasim
commented
Aug 19, 2022
michaelkirk
approved these changes
Aug 19, 2022
urschrei
approved these changes
Aug 20, 2022
|
bors r=michaelkirk,urschrei |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2022
203: mismatch type error r=metasim a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Fixes #201 ~~Based on #202, so let's merge that first.~~ merged! Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Reworked current implementation to use borrowed values, and created macro to generate owned value variants that delegate to the borrowed value ones.
Note: Until #201 is addressed, invalid geometry conversions will be cloned during error reporting.