mismatch type error #203
Merged
mismatch type error #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/mismatch-type-error
branch
from
a60bb64
to
c7fcdf1
Compare
metasim
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
@michaelkirk Thanks for doing this... glad to get that clone out of there!
LGTM.
metasim
reviewed
Aug 25, 2022
| let mut map = JsonObject::new(); | ||
| let ty = String::from(match value { | ||
| impl Value { | ||
| pub fn type_name(&self) -> &'static str { |
|
bors r=metasim |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #201
Based on #202, so let's merge that first.merged!