[BUG/ISSUE] Parsing HEMCO_Config.rc emissions switches is not robust #150
Assignees
Labels
category: Bug
Something isn't working
topic: Configuration Files
Related to HEMCO configuration files
Milestone
Comments
yantosca
added
the
topic: Configuration Files
yantosca
added a commit
that referenced
this issue
Jun 24, 2022
src/Core/hco_chartools_mod.F90 - Call string routine CSTRIP (with KeepSpaces=T). This will remove any non-printing characters (but preserve spaces) from each line that is read in from HEMCO_Config.rc. - Also check each line read from HEMCO_Config.rc for the position of the comment character. If a comment character is found in column 1, do nothing (as this is a commment line). But if a comment character is found elsewhere in the line, then ignore all characters at or after the position of the comment character. This commit should fix the issue raised in geoschem/HEMCO #150. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
This should now be resolved by PR #151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Investigation of a GCHP bug (geoschem/GCHP#225) revealed that emissions are not used if the HEMCO switch in config file
HEMCO_Config.rccontains tabs.For example, the following line:
--> HTAPv3 : true # 2000-2018is interpreted as HTAPv3 true only if all of the whitespace is spaces. Replacing it with tabs makes it be interpreted as false.
A few months ago I also noticed that including true or false after the comment character (
#) can interfere with correct interpretation of the line.We need to revisit how these lines in the config file are parsed to make them more robust.
The text was updated successfully, but these errors were encountered: