Strip out tabs and end-of-line comments when reading from HEMCO_Config.rc -- Closes #150 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Core/hco_chartools_mod.F90 - Call string routine CSTRIP (with KeepSpaces=T). This will remove any non-printing characters (but preserve spaces) from each line that is read in from HEMCO_Config.rc. - Also check each line read from HEMCO_Config.rc for the position of the comment character. If a comment character is found in column 1, do nothing (as this is a commment line). But if a comment character is found elsewhere in the line, then ignore all characters at or after the position of the comment character. This commit should fix the issue raised in geoschem/HEMCO #150. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
the
topic: Configuration Files
|
Thanks so much for making this, it was a major source of debugging headaches 😟 |
|
No problem @jimmielin. We already had similar code in the GEOS-Chem Classic HISTORY code, so it was pretty easy to add this into HEMCO. |
|
GCHP integration tests all passed: ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
|
The GEOS-Chem Classic integration tests timed out (maybe due to issues on the cluster). I have resubmitted them and will post results when available. |
|
GCC integration tests all passed Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 48
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
msulprizio
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue raised in #150. We now strip out the following from each line read from HEMCO_Config.rc:
Integration tests pending.