PNG output / Make sure rule icons are correctly drawn #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to wait for the image to properly load the data encoded as base64 Also adjusted the jest config to let JSDOM know that it should actually load image resourcs, see: https://github.com/jsdom/jsdom#loading-subresources This is required for the 'load' event of the image to trigger in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where, under certain conditions, some rule icons were not correctly rendered in the legend.
This is because the png output does not wait for the
loadevent of the rule icon images. This would sometimes give empty rule icons like so:This PR makes sure that the images are always loaded before being drawn in the legend, by making the
addImagemethod asynchronous. This does not impact the API of the library, nor the SVG output which did not face this issue in the first place.Found as part of camptocamp/inkmap#61