Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to IFD parsing: Not all IFDs are parsed alltogether unless necessary #136

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

constantinius
Copy link
Member

Related to #132

@ilan-gold
Copy link
Contributor

Hi @constantinius, Could I take over finishing PR, if you'd be ok with that? Or is there something complicated going on here that I am missing? Sorry to push this, but I have capacity and would love to get this functionality.

@constantinius
Copy link
Member Author

Hi @ilan-gold
Sorry for keeping you waiting. I think the PR is almost done anyways, there is just something wrong with the writer. If you have capacities to do that, go ahead! I'm quite full, to be honest!
Also, extensive testing would be great!

@ilan-gold ilan-gold mentioned this pull request Apr 7, 2020
* Add multi-channel tiff and update tests

* More comprehensive testing

* Refactor a bit
@constantinius constantinius marked this pull request as ready for review April 8, 2020 21:17
@ilan-gold
Copy link
Contributor

Hi @constantinius, sorry to bug, but is this ready to merge? Can I help with the merge conflict?

@constantinius constantinius merged commit 7561f39 into master Apr 17, 2020
@constantinius constantinius deleted the ifd-reading branch April 17, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants