Add multi-channel tiff and update tests #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to add a few more tests. |
|
Nice, thanks for the fix. I think we could have used TIFFs with overviews instead but I think its good to use more diverse test data. Adding more tests is always welcome, let me know when this is done on your side! |
|
I think this covers what I was looking to do. Good to go! |
|
Thanks a lot! |
constantinius
added a commit
that referenced
this pull request
Apr 17, 2020
…ss necessary (#136) * Improvements to IFD parsing: Not all IFDs are parsed alltogether unless necessary. WiP * Add multi-channel tiff and update tests (#141) * Add multi-channel tiff and update tests * More comprehensive testing * Refactor a bit Co-authored-by: ilan-gold <43999641+ilan-gold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we just needed to get rid of the now defunct
fileDirectoriesvalue. I also added a test using a file I uploaded for something else that has multiple image pages.