Fix: support links with only query parameters

[jounimakela]

This commit resolves an issue where links containing only query parameters without a specified path would incorrectly direct to the root path instead of the current path, unlike standard browser behavior.

Example of a link without a path:

<a href="?lang=en">English</a>

Previously, click_link/2 would direct to root path. In this commit the link correctly retains the current page while applying the query parameters.

[germsvel]

@jounimakela thanks for opening this issue.

I think the problem isn't with phoenix_test itself. We're passing the path to Phoenix.ConntTest.get, which seems to treat that as the root path. Would you mind opening an issue in that repo?

I think if we want to fix that here, we should fix it for all links and not just for when we do a click on static pages. That means we should probably clean up the path that is passed to PhoenixTest.visit/2before sending it to Phoenix.ConnTest.get/2.

You can see that here:

phoenix_test/lib/phoenix_test.ex

Lines 214 to 215 in e1a2408

	def visit(conn, path) do
	case get(conn, path) do

I'm open to the idea of us handling it here (in visit/2) and opening an issue in Phoenix.ConnTest (just to let them know. not sure if they'd fix it). Would you be up for that?

[germsvel]

I think this is also related to #72 (though probably need different fixes). Just noting that here.

[germsvel]

@jounimakela any thoughts on my comment from before? (#80 (comment))

[jounimakela]

Apologies for my delayed response.

I'm open to the idea of us handling it here (in visit/2) and opening an issue in Phoenix.ConnTest (just to let them know. not sure if they'd fix it). Would you be up for that?

Sounds good! I'll make a proposal for a fix and open an issue.

[germsvel]

Thank you! 🎉 And no apologies needed. This is open source, so we all work on it when we can. 😄

Just wanted to check if this was still something you wanted to fix, and was doing my due diligence here.

[jounimakela]

Fixing the path is now in PhoenixTest.visit/2. I am not too happy about having the helper function in the top-level module.

I'll also squash commits once we are happy with the changes.

Thoughts?

[germsvel]

Thanks for making the change!

---

I am not too happy about having the helper function in the top-level module.

Yeah, I agree. Something about it doesn't feel great. I think it's because if feels like a band-aid (which it is) on something that Phoenix.ConnTest should handle.

Were you able to open the issue on the phoenix repo? I'd love for this to be fixed there, and we can include the band-aid here until it's fixed. But I don't want to include the band-aid in PhoenixTest forever.

[jounimakela]

Were you able to open the issue on the phoenix repo? I'd love for this to be fixed there, and we can include the band-aid here until it's fixed. But I don't want to include the band-aid in PhoenixTest forever.

Open now! phoenixframework/phoenix#5877

[jounimakela]

@germsvel looks like Phoenix.ConnTest.get isn't going to change.