Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support links with only query parameters #80

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: support links with only query parameters #80

wants to merge 4 commits into from

Commits on Jul 10, 2024

  1. Fix: support links with only query parameters 

    This commit resolves an issue where links containing only query
parameters without a specified path would incorrectly direct to the root
path instead of the current path, unlike standard browser behavior.

Example of a link without a path:

    <a href="?lang=en">English</a>

Previously, `click_link/2` would direct to root path. In this commit the
link correctly retains the current page while applying the query
parameters.
    @jounimakela
    jounimakela committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5854969 View commit details
    Browse the repository at this point in the history

  2. Add LiveView test for links with only query params

    @jounimakela
    jounimakela committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a30065b View commit details
    Browse the repository at this point in the history

  3. Support links with only query params

    @jounimakela
    jounimakela committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5edf89e View commit details
    Browse the repository at this point in the history

  4. Remove previous fix

    @jounimakela
    jounimakela committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dcabed2 View commit details
    Browse the repository at this point in the history