Update to jdeb 1.10 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesellix
commented
Apr 19, 2022
| @@ -47,35 +47,35 @@ class BuildDebianPackageTaskSpec extends Specification { | |||
| def e = thrown(expectedException) | |||
| e.message =~ exceptionMessagePattern | |||
| where: | |||
| taskConfig || expectedException | exceptionMessagePattern | |||
| taskConfig || expectedException | exceptionMessagePattern ; | |||
There was a problem hiding this comment.
gesellix
force-pushed
the
jdeb-1.6
branch
2 times, most recently
from
49ce8d6 to
6889481
Compare
gesellix
force-pushed
the
jdeb-1.6
branch
2 times, most recently
from
15d2356 to
36c0a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to tcurdt/jdeb#264, which had been addressed in tcurdt/jdeb@c6fe2a3.
The issue's cause had been released with JDeb 1.6, containing commit tcurdt/jdeb@c8acbf9, which in turn includes the breaking change of commons-compress 1.11: apache/commons-compress@68db5fa
Currently, it seems like JDeb 1.7 and 1.8 produce absolute instead of relative paths, which makes
lintianfail.Updates to JDeb 1.7 or 1.8 would require a release of tcurdt/jdeb#336
We're now going to update to JDeb 1.10, see tcurdt/jdeb#364.