Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in creating directory with DataProducer together with PermMapper between version 1.4 and 1.6 #264

Closed
chali opened this issue Apr 27, 2018 · 2 comments
Labels

Comments

@chali
Copy link
Contributor

chali commented Apr 27, 2018

We are creating directories using DataProducerPathTemplate and setting permission using PermMapper When I'm reading the content of produced deb I see different results between jdeb 1.4 and 1.6. I register directory /var/logs/directory with 1.4 I'm reading /var/logs/directory with 1.6 I'm getting //var/logs/directory

I believe it is related to change in version of commons-compress from 1.8 to 1.15 and its different implementation of setName used in PermMapper

setName in commons-compress:1.8
setName in commons-compress:1.15

Here is an complete example which shows the difference

@tcurdt tcurdt added the bug label Apr 28, 2018
@tcurdt
Copy link
Owner

tcurdt commented Apr 28, 2018

I remember a discussion that paths actually should be relative all the time with no leading slashes at all. I guess this needs to be checked and the code adjusted accordingly.

@tcurdt tcurdt added this to the 1.7 milestone Aug 2, 2018
@tcurdt tcurdt closed this as completed in c6fe2a3 Oct 5, 2018
@tcurdt
Copy link
Owner

tcurdt commented Oct 5, 2018

Thanks for digging into this. Seems like it really was just a bug in the PermMapper.
The right thing to do would be write a test case for the PermMapper, but I think it shoulds be fixed now. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants