Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cln #123

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Feature/cln #123

wants to merge 9 commits into from

Conversation

kiwiidb
Copy link
Contributor

@kiwiidb kiwiidb commented Mar 4, 2022

This draft PR is meant to track C-Lightning support. According to rumours, @cdecker is working on an official gRPC interface for C-Lightning. So we should rewrite this PR once that is released, so we don't have to rely on the Sparko plugin anymore.

@urza
Copy link

urza commented Jun 5, 2022

There was some grpc support aded to CLN in 0.11

https://github.com/ElementsProject/lightning/releases/tag/v0.11.0.1

What exactly is needed?

@prusnak
Copy link
Contributor

prusnak commented Jun 5, 2022

Here is the official cln-grpc plugin documentation: https://lib.rs/crates/cln-grpc and its API reference: https://docs.rs/cln-grpc/latest/cln_grpc/

@kiwiidb
Copy link
Contributor Author

kiwiidb commented Jun 6, 2022

There are 2 things that are needed right now:

  • CLN gRPC interface is missing certain methods, for example we use the decode method to decode a bolt11 (I outsourced this to the LN node to reduce dependencies in the lndhub.go code).
  • I am waiting on an answer on this question, on how to connect remotely using mTLS.

I will create a new PR for CLN gRPC support and close this one later because it is outdated.

@prusnak
Copy link
Contributor

prusnak commented Jun 6, 2022

  • CLN gRPC interface is missing certain methods, for example we use the decode method to decode a bolt11 (I outsourced this to the LN node to reduce dependencies in the lndhub.go code).

I agree with the sentiment here. However, if CLN gRPC is not adding this, you can use for example this: https://github.com/nbd-wtf/ln-decodepay

@kiwiidb
Copy link
Contributor Author

kiwiidb commented Sep 7, 2022

I've updated this PR but stumbled upon another issue which blocks CLN integration: C-Lightning doesn’t support creating an invoice with a description_hash as input parameter (it needs the description and does the hashing itself).

@prusnak prusnak mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants