Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and whitespace #211

Merged
merged 3 commits into from
Jul 16, 2022
Merged

Fix typo and whitespace #211

merged 3 commits into from
Jul 16, 2022

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Jul 11, 2022

No description provided.

Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooppps... I am horrible at seeing typos, should have seen this in the review.

README.md Outdated
@@ -75,7 +75,7 @@ Alternatively you can also use the [Alby simnetwork](https://github.com/getAlby/

## Database

LndHub.go requires a PostgreSQL database backend.
LNDhub.go requires a PostgreSQL database backend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LNDhub or LndHub? :)

hehe, everytime I write lndhub I look somewhere to see how it's written... and probably everytime I look somewhere where it is different :D

Copy link
Contributor Author

@prusnak prusnak Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used LndHub for the original project and LNDHub.go for this project, because that's how they are used in most of the places already.

We can use "LndHub.go" if you want, but then we'd need to regenerate static/img/logo.png linked from the README.md and I don't know how to do that ;-)

Another option is to edit static/img/logo.png to contain only the logo and replace the text stored in the image with the markdown text.

Copy link
Contributor Author

@prusnak prusnak Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And finally, there is a third option ...

If there is a still plan to support CLN (#123) we might as well rename the whole project to something completely new (AlbyHub or LightningHub come to mind?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving it more thought today - I updated the PR to use LndHub and LndHub.go constistently and simplified the logo (to not contain the text) and the README. I think that's the best way to proceed and also opens the door in case we want to rename the project since the text is no longer part of the logo.

@kiwiidb kiwiidb merged commit 85440eb into getAlby:main Jul 16, 2022
@prusnak prusnak deleted the typo branch July 16, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants